Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Wizard): implement success status on steps / nav items #10714

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

nicolethoen
Copy link
Contributor

@nicolethoen nicolethoen commented Jul 9, 2024

Closes #10691

updated Step status example in wizard docs: https://patternfly-react-pr-10714.surge.sh/components/wizard#step-status

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 9, 2024

@nicolethoen nicolethoen linked an issue Jul 9, 2024 that may be closed by this pull request
@andrew-ronaldson andrew-ronaldson self-requested a review July 16, 2024 15:32
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks good

@nicolethoen nicolethoen requested a review from kmcfaul July 16, 2024 15:46
@wise-king-sullyman wise-king-sullyman requested review from wise-king-sullyman and removed request for kmcfaul July 16, 2024 15:50
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we lost the step number in the toggle for all steps that don't have a status

https://patternfly-react-pr-10714.surge.sh/components/wizard/react/basic/

Screenshot 2024-07-16 at 11 59 46 AM

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above lgtm, looks like it's just to do with isActiveStepStatus not having any default value within WizardToggle

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙‍♂️

@wise-king-sullyman wise-king-sullyman merged commit aef93f3 into patternfly:v6 Jul 19, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard - create success status wizard nav items
7 participants